Add zOS UpcallThunkGen function stubs #15873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChengJin01 / @tajila : Can you review? Thanks! |
joransiu
force-pushed
the
upcall_thunk_zos
branch
from
cc7c9a4
to
fd54fac
Compare
|
I have tested this with SPEC 17 internally on z/OS, and build now completes successfully:
|
|
Overall, the changes Look good to me. |
ChengJin01
reviewed
Sep 12, 2022
runtime/vm/mz64/UpcallThunkGen.cpp
Outdated
| void * | ||
| createUpcallThunk(J9UpcallMetaData *metaData) | ||
| { | ||
| // Return the thunk descriptor |
There was a problem hiding this comment.
Please replace the comment // with /*...*/.
Add empty stub function implementations for upcall thunk generation support to allow OpenJ9 to build on z/OS with spec version >= 16. Actual implementation of the upcall thunks to be implemented in the future. Signed-off-by: Joran Siu <joransiu@ca.ibm.com>
joransiu
force-pushed
the
upcall_thunk_zos
branch
from
fd54fac
to
dae6849
Compare
|
@tajila : Can you review when you get a chance? Would like to get zOS builds working again. Thanks! |
tajila
approved these changes
Sep 19, 2022
|
I guess there isnt a PR build that we can run to test this ATM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add empty stub function implementations for upcall thunk generation support to allow OpenJ9 to build on z/OS with spec version >= 16.
Actual implementation of the upcall thunks to be implemented in the future.
Signed-off-by: Joran Siu joransiu@ca.ibm.com