Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --build optional parameter to mkdocker.sh to allow use of podman #15888

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

kgibm
Copy link
Contributor

@kgibm kgibm commented Sep 14, 2022

Fixes #15887

Adds an optional parameter to --build to specify the container engine (default docker). If --build without an engine is specified and docker is not on $PATH and podman is on $PATH, then the engine will default to podman. If the engine is not on $PATH, an error is printed.

$ bash mkdocker.sh --tag=openj9 --dist=ubuntu --version=16.04 --gitcache=no --jdk=8 --build=podman
[...]
COMMIT openj9
--> fc6baf7ddcb
Successfully tagged localhost/openj9:latest

Signed-off-by: Kevin Grigorenko kevin.grigorenko@us.ibm.com

@keithc-ca
Copy link
Contributor

What do you think about using the existing --build option instead?

Given a value it would specify the builder to use (still defaulting to docker).

Either way, I think some validation of the value is appropriate (at least that it names an executable).

@kgibm
Copy link
Contributor Author

kgibm commented Sep 15, 2022

What do you think about using the existing --build option instead?

Given a value it would specify the builder to use (still defaulting to docker).

Either way, I think some validation of the value is appropriate (at least that it names an executable).

That's a good idea. I'll also add validation. I'm out of the office the rest of this week but will pick this up on Monday.

@kgibm
Copy link
Contributor Author

kgibm commented Sep 19, 2022

@keithc-ca Please re-review

buildenv/docker/mkdocker.sh Outdated Show resolved Hide resolved
buildenv/docker/mkdocker.sh Outdated Show resolved Hide resolved
@dsouzai
Copy link
Contributor

dsouzai commented Sep 19, 2022

@kgibm could you also update the PR subject / description to reflect the current changes?

@kgibm
Copy link
Contributor Author

kgibm commented Sep 19, 2022

@kgibm could you also update the PR subject / description to reflect the current changes?

Sure. Updated.

@kgibm kgibm changed the title Add --engine flag to mkdocker.sh to allow use of podman Add --build optional parameter to mkdocker.sh to allow use of podman Sep 19, 2022
buildenv/docker/mkdocker.sh Outdated Show resolved Hide resolved
@keithc-ca
Copy link
Contributor

Please squash in preparation for merging.

Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
@kgibm
Copy link
Contributor Author

kgibm commented Sep 20, 2022

Squashed and pushed

@keithc-ca keithc-ca merged commit b9b7339 into eclipse-openj9:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mkdocker.sh doesn't support podman
4 participants