Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print full exception details if a jdmpview !-command throws an exception #15890

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

kgibm
Copy link
Contributor

@kgibm kgibm commented Sep 14, 2022

Fixes #15889

Problem running command:
java.nio.BufferOverflowException
	at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:194)
	at java.nio.ByteBuffer.put(ByteBuffer.java:867)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.TraceFileHeaderWriter.writeStartupSection(TraceFileHeaderWriter.java:331)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.TraceFileHeaderWriter.writeTraceFileHeader(TraceFileHeaderWriter.java:203)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.TraceFileHeaderWriter.createAndWriteTraceFileHeader(TraceFileHeaderWriter.java:164)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.SnapBaseCommand.createAndWriteTraceFileHeader(SnapBaseCommand.java:177)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.SnapBaseCommand.extractTraceData(SnapBaseCommand.java:88)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.SnapFormatCommand.run(SnapFormatCommand.java:458)
	at com.ibm.j9ddr.tools.ddrinteractive.commands.SnapFormatWrapperCommand.run(SnapFormatWrapperCommand.java:70)
	at com.ibm.j9ddr.tools.ddrinteractive.Context.tryCommand(Context.java:229)
	at com.ibm.j9ddr.tools.ddrinteractive.Context.execute(Context.java:202)
	at com.ibm.j9ddr.tools.ddrinteractive.DDRInteractive.execute(DDRInteractive.java:356)
	at com.ibm.j9ddr.command.CommandReader.processLine(CommandReader.java:78)
	at com.ibm.j9ddr.tools.ddrinteractive.DDRInteractive.processLine(DDRInteractive.java:331)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.ibm.jvm.dtfjview.CombinedContext.executeDDRInteractiveCommand(CombinedContext.java:258)
	at com.ibm.jvm.dtfjview.CombinedContext.execute(CombinedContext.java:169)
	at com.ibm.jvm.dtfjview.Session.execute(Session.java:813)
	at com.ibm.jvm.dtfjview.Session.execute(Session.java:767)
	at DTFJTest.main(DTFJTest.java:15)

Signed-off-by: Kevin Grigorenko kevin.grigorenko@us.ibm.com

Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
@pshipton
Copy link
Member

If it's useful, we could double deliver this to 0.35

@pshipton
Copy link
Member

btw, there is no requirement to create an Issue for every PR. If you already have a fix you could just put the details into the PR.

@kgibm
Copy link
Contributor Author

kgibm commented Sep 14, 2022

If it's useful, we could double deliver this to 0.35

No urgency, so only if it's minimal effort to do that.

btw, there is no requirement to create an Issue for every PR. If you already have a fix you could just put the details into the PR.

Makes sense, will do.

By the way, I haven't gotten into the habit of running tests. As I'm spending most of my time in DTFJ, what would be the easiest way to run local DTFJ regression/unit tests to make sure I haven't broken any?

@pshipton
Copy link
Member

pshipton commented Sep 14, 2022

Depending on the risk of breaking something, and what you want to run:

  • create a PR and have somebody start a PR build
  • start an IBM internal personal build with your changes, running the suites needed (like sanity, extended to cover all DDR testing)
  • start a personal build to compile the JVM, and then use a grinder to run the suites you want by listing them out using "testList TESTLIST=` in the TARGET
  • run tests manually using https://github.com/eclipse-openj9/openj9/blob/master/test/README.md

@keithc-ca
Copy link
Contributor

jenkins compile amac jdk19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running a ! command in jdmpview that throws an error provides few details
3 participants