Fix the cast issue with return values in dispatcher for FFI upcall

[ChengJin01]

The changes fix the cast issue with the values returned from native2InterpJavaUpcallImpl().

Signed-off-by: Cheng Jin jincheng@ca.ibm.com

[ChengJin01]

Reviewer: @keithc-ca
FYI: @tajila

[keithc-ca]

Other comments/questions:

• in native2InterpJavaUpcallImpl

  • returnStorage should be of type U_64
  • line 244 can be simplified to returnsObject = (J9NtcPointer == returnType) || (J9NtcStruct == returnType);
  • lines 297-299: why is the shift only applied for float?
  • please fix the comment on line 300 which should be /* !defined(J9VM_ENV_LITTLE_ENDIAN) */
  • please fix the indentation on lines 337-339

• please add the missing space before ( on line 426

[ChengJin01]

returnStorage should be of type U_64

Updated at all places using returnStorage.

[ChengJin01]

line 244 can be simplified to returnsObject = (J9NtcPointer == returnType) || (J9NtcStruct == returnType);

Agreed and fixed as suggested.

[ChengJin01]

lines 297-299: why is the shift only applied for float?

We have java code to specially handle float by converting to int at first and further to long in downcall handler at

openj9/jcl/src/java.base/share/classes/openj9/internal/foreign/abi/InternalDowncallHandler.java

Line 191 in f3810df

private static final long floatToLongArg(float argValue) {

, in which case we need to address this case in native before passing it on the java stack in upcall on the Big-Endian(BE) platforms. I just updated the comment for clarification.

[ChengJin01]

please fix the comment on line 300 which should be /* !defined(J9VM_ENV_LITTLE_ENDIAN) */
please fix the indentation on lines 337-339

Fixed.

[keithc-ca]

I think this has reached a good place. Please let me know whether your testing confirms that.

[keithc-ca]

Can you fix these minor things:

• the missing period on lines 165, 207, 219, 400, 419, 449 & 616
• the indentation of lines 320-322

[ChengJin01]

the missing period on lines 165, 207, 219, 400, 419, 449 & 616
the indentation of lines 320-322

Fixed.

[keithc-ca]

Thanks for fixing the other minor issues I missed. ;-)

[keithc-ca]

jenkins test sanity alinux64 jdk19