Handle vector mask testAny, testAll and conversion opcodes in VectorAPIExpansion #15960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
9413725
to
2672ea0
Compare
|
Fixed line endings |
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
2672ea0
to
00d4497
Compare
|
Fixed more line endings. |
gita-omr
changed the title
|
WIP since required OMR PR is WIP. |
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
00d4497
to
ce3812f
Compare
|
Rebased. |
Akira1Saitoh
reviewed
Oct 3, 2022
| @@ -1212,7 +1258,10 @@ TR::Node *TR_VectorAPIExpansion::transformLoadFromArray(TR_VectorAPIExpansion *o | |||
| TR::Node *aladdNode = generateAddressNode(array, arrayIndex, elementSize); | |||
There was a problem hiding this comment.
I believe elementSize must be 1 for mask load. Otherwise, the offset into the byte array is incorrectly scaled as in the ILtree below.
198804 n9134n i2mVector128Int32 () [ 0x10c4616d0] bci=[30,47,208] rc=2 vc=5787 vn=- li=- udi=- nc 198804 =1 flg=0x28
198805 n10244n iloadi <array-shadow>[#206 Shadow] [flags 0x80000603 0x0 ] [ 0x10c7671c0] bci=[30,47,208] rc=1 vc=0 vn=- li=- udi=- nc=1
198806 n10233n aladd [ 0x10c766e50] bci=[-1,0,40] rc=1 vc=0 vn=- li=- udi=- nc=2
198807 n9110n ==>aload
198808 n10231n ladd [ 0x10c766db0] bci=[-1,0,40] rc=1 vc=0 vn=- li=- udi=- nc=2
198809 n10229n lshl [ 0x10c766d10] bci=[-1,0,40] rc=1 vc=0 vn=- li=- udi=- nc=2
198810 n9121n ==>lload
198811 n10230n iconst 2 [ 0x10c766d60] bci=[-1,0,40] rc=1 vc=0 vn=- li=- udi=- nc=0
198812 n10232n lconst 24 [ 0x10c766e00] bci=[-1,0,40] rc=1 vc=0 vn=- li=- udi=- nc=0
ce3812f
to
aa88be9
Compare
|
Fixed aliasing bug when reading mask from byte array. |
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
6e34895
to
bca197b
Compare
|
Changed code to use |
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
dcd3acf
to
a145b7a
Compare
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
a145b7a
to
8ded3f9
Compare
gita-omr
changed the title
knn-k
reviewed
Oct 12, 2022
knn-k
reviewed
Oct 12, 2022
knn-k
reviewed
Oct 14, 2022
knn-k
reviewed
Oct 14, 2022
knn-k
reviewed
Oct 14, 2022
gita-omr
force-pushed
the
test_intrinsic_j9
branch
from
8ded3f9
to
f551874
Compare
|
Addressed all comments above. |
|
Jenkins test sanity all jdk19 depends eclipse/omr#6690 |
knn-k
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on eclipse/omr#6690