Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtualThreadInspectorCount check #15965

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

fengxue-IS
Copy link
Contributor

@fengxue-IS fengxue-IS commented Sep 26, 2022

Enforce synchronization: Avoid mounting a virtual thread while unmounting.

Related: #15938

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

@fengxue-IS fengxue-IS added the project:loom Used to track Project Loom related work label Sep 26, 2022
@fengxue-IS
Copy link
Contributor Author

Test passed with this change using --enable-preview -Dvm.continuations=true -Xgcpolicy:optthruput -Xint -Xnocompressedrefs java option.

This test will fail with compressedrefs due to java.lang.OutOfMemoryError: native memory exhausted during createContinuationImpl. The test seem to be spawning 1 million+ vthreads which consumes all of sub 4G space
FYI @gacholio

@fengxue-IS fengxue-IS marked this pull request as ready for review September 26, 2022 20:22
@babsingh
Copy link
Contributor

Re-phrase the commit message.

Enforce synchronization: Avoid mounting a virtual thread while unmounting, and vice-versa.

Enforce synchronization: Avoid mounting a virtual thread while unmounting.

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@babsingh
Copy link
Contributor

jenkins test sanity amac jdk19

@babsingh babsingh merged commit 02c32d0 into eclipse-openj9:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:loom Used to track Project Loom related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants