Add missing relos in dumpRelocationHeaderData #16017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TR_InlinedStaticMethod, TR_InlinedSpecialMethod, and TR_InlinedAbstractMethod were missed in the debug code that dumps out the relocation data. As the codes tands, if the compiler generates these relocations, it will assert when trying to dump. Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
|
@dchopra001 @jdmpapin could you please review? |
|
jenkins test sanity.functional xlinux jdk17 |
|
@jdmpapin review reminder :) |
jdmpapin
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR_InlinedStaticMethod, TR_InlinedSpecialMethod, and TR_InlinedAbstractMethod were missed in the debug code that dumps out the relocation data. As the code stands, if the compiler generates these relocations, it will assert when trying to dump.
Signed-off-by: Irwin D'Souza dsouzai.gh@gmail.com