Update Continuation.yield to use onPinned API #16024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure seen in #16011 is due to VirtualThreadTest expected |
fengxue-IS
force-pushed
the
cont_onpinned
branch
from
e0465f4
to
8bc082e
Compare
|
this should be tested/merged after #16025 to ensure test coverage |
|
jenkins test sanity amac,zlinux,win,xlinux,aix jdk19 |
|
PR build result: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/2794/ |
fengxue-IS
force-pushed
the
cont_onpinned
branch
from
8bc082e
to
f67e96a
Compare
|
@babsingh can you please take another look |
Continuation class implementation expects IllegalStateException when yielding a pinned Continuation. But VirtualThread class overrides this behaviour and only returns false without throwing the exception when yield fails. - Allow the overriden onPinned method to perform non-throw behaviour when the Continuation is pinned during yield. - Update VirtualThread tests on new behaviour Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
fengxue-IS
force-pushed
the
cont_onpinned
branch
from
f67e96a
to
b72ea42
Compare
babsingh
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation class implementation expects IllegalStateException when
yielding a pinned Continuation. But VirtualThread class overrides
this behaviour and only returns false without throwing the exception
when yield fails.
when the Continuation is pinned during yield.
Rework of #15996
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com