Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Gencon/Balanced/OptAvgPause GC policy in testing #16069

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Enable Gencon/Balanced/OptAvgPause GC policy in testing #16069

merged 1 commit into from
Oct 13, 2022

Conversation

fengxue-IS
Copy link
Contributor

Signed-off-by: Jack Lu Jack.S.Lu@ibm.com

@fengxue-IS
Enable Gencon/Balanced/OptAvgPause GC policy in testing
b46aa21 
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
@fengxue-IS
Copy link
Contributor Author

Per discussion with Lin, GC policy have been updated to support VirtualThread/Continuation
@LinHu2016 can you please review this

@fengxue-IS fengxue-IS added comp:test comp:gc project:loom Used to track Project Loom related work labels Oct 6, 2022
@LinHu2016
Copy link
Contributor

LGTM

@pshipton
Copy link
Member

pshipton commented Oct 7, 2022

Trying the test on a number of platforms
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1330/

@pshipton
Copy link
Member

pshipton commented Oct 7, 2022 •
edited
Loading

A crash running balanced on most platforms. It didn't crash on AIX, and I didn't run xlinux.
https://openj9-jenkins.osuosl.org/job/Grinder/1331/tapResults/ - alinux
https://openj9-jenkins.osuosl.org/job/Grinder/1336/tapResults/ - plinux
https://openj9-jenkins.osuosl.org/job/Grinder/1332/consoleFull - windows
https://openj9-jenkins.osuosl.org/job/Grinder/1334/tapResults/ - amac
https://openj9-jenkins.osuosl.org/job/Grinder/1333/tapResults/ - xmac
https://openj9-jenkins.osuosl.org/job/Grinder/1337/console - zlinux

@pshipton pshipton marked this pull request as draft October 7, 2022 18:46
@pshipton
Copy link
Member

pshipton commented Oct 7, 2022

A crash running balanced on most platforms, see the previous comment for details.

@LinHu2016 LinHu2016 mentioned this pull request Oct 11, 2022
Merged
@dmitripivkine
Copy link
Contributor

A crash running balanced on most platforms, see the previous comment for details.

Crash in Balanced and incomplete handling in Gencon
Fixing the problem in #16087

@babsingh
Copy link
Contributor

Reopening, accidentally closed by #16087.

@babsingh babsingh reopened this Oct 12, 2022
@fengxue-IS
Copy link
Contributor Author

@LinHu2016 can you take another look please

@pshipton
Copy link
Member

pshipton commented Oct 12, 2022 •
edited
Loading

New grinder https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1374/

@pshipton
Copy link
Member

I guess we need to wait until tomorrow, as the fix was just merged today and I'm using nightly builds for the testing.

@pshipton
Copy link
Member

pshipton commented Oct 13, 2022 •
edited
Loading

https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1383
Rebuild for xlinux to avoid centos6 - https://openj9-jenkins.osuosl.org/job/Grinder/1392/
Previous grinder passed. Run more iterations, 5x x 5 machines.
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1393/ - infra issue on zlinux 2/5 machines, but otherwise it all passed.

@LinHu2016
Copy link
Contributor

LGTM

@pshipton pshipton marked this pull request as ready for review October 13, 2022 17:30
@pshipton pshipton merged commit e8abb75 into eclipse-openj9:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:gc comp:test project:loom Used to track Project Loom related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fengxue-IS @LinHu2016 @pshipton @dmitripivkine @babsingh