Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain allocated data in TestNogcDieWithOOM test #16179

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Retain allocated data in TestNogcDieWithOOM test #16179

merged 1 commit into from
Oct 24, 2022

Conversation

pshipton
Copy link
Member

@pshipton
Retain allocated data in TestNogcDieWithOOM test
bb4a99b 
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton pshipton requested a review from amicic October 24, 2022 16:30
@pshipton pshipton mentioned this pull request Oct 24, 2022
Closed
@amicic
Copy link
Contributor

amicic commented Oct 24, 2022

Looks good (better than before), although we could go further and use some of variables, for example print cnt value or the double array address, to really make sure this block is not eliminated as dead.

@amicic amicic merged commit dad0da8 into eclipse-openj9:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amicic amicic amicic approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcPolicyNogcOOMTest testDieWithOOM Expecting Out of Memory Error!
2 participants
@pshipton @amicic