Get threadObject from targetThread in mgmtthread.c::getThreadInfo #16181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the typo introduced in eclipse-openj9#15956. targetThread should be used instead of currentThread for retrieving the threadObject. Related: eclipse-openj9#14538 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
@thallium Can you please review this PR? |
|
jenkins test sanity,extended amac jdk19,jdk11 |
|
@pshipton Tested locally some of the failing test targets, which are reported in #14538 (comment). They successfully pass with this PR. It should be good to merge once the PR builds pass. |
|
Seems jdk11 extended testing has hung in testDDRExtJunit_MonitorsAndDeadlock6_0 |
|
The test passed in a grinder, hopefully we just got unlucky, although I don't recall seeing a hang like this before. Perhaps there is another intermittent problem, but I don't think it's related to this change. |
pshipton
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the typo introduced in #15956.
targetThreadshould be used insteadof
currentThreadfor retrieving thethreadObject.Related: ce4d4a3#r87746489
Related: #14538
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com