AArch64: Stop generating a dmb for allocationFence when possible #16199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR stops generating a dmb instruction for allocationFence on AArch64 if the node is followed by monexit, for reducing memory synchronization. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
This PR depends on #16119. |
|
Based on the changes for p in #16119. By default the monexitEvaluator for AArch64 uses the STLR (Store-Release Register) instruction, which forces the memory ordering. The evaluator uses the DMB instruction instead of STLR when AArch64 JIT does not support LockReservation, and this PR does not have the change for LockReservation. |
|
Jenkins test sanity alinux64 jdk11,jdk17 |
0xdaryl
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops generating a dmb instruction for allocationFence on AArch64 if the node is followed by monexit, for reducing memory synchronization.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com