Make VP erase interface types in array types from signatures #16316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of the method is copied verbatim from the definition currently in OMR. Once merged, this copy will allow the Java-specific logic to be removed from OMR while still using it in OpenJ9. Factoring the logic into its own method allows for it to be fixed (to handle array-of-interface types) in a single place.
The verifier treats interface types as java/lang/Object even within array component types. In particular, when any parameter, instance or static field, or return type is declared with a signature naming an array of an interface type, its value is guaranteed to be a reference array, but not necessarily the named array type. For example, if a parameter is declared to be of type List[], it can actually be any Object[].
jdmpapin
added
comp:jit
depends:omr
|
This depends on eclipse-omr/omr#6814 |
|
@vijaysun-omr, could you please review? |
vijaysun-omr
approved these changes
Nov 18, 2022
|
Jenkins test sanity all jdk17 |
|
Checks have passed. Merging. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verifier treats interface types as
java/lang/Objecteven within array component types. In particular, when any parameter, instance or static field, or return type is declared with a signature naming an array of an interface type, its value is guaranteed to be a reference array, but not necessarily the named array type. For example, if a parameter is declared to be of typeList[], it can actually be anyObject[].There is one preparatory refactoring commit: