Fix the return type of VectorSupport.fromBitsCoerced #16330
Conversation
|
@gita-omr Can you please review this? Thanks. |
| } | ||
| else if (methodSymbol->getRecognizedMethod() == TR::jdk_internal_vm_vector_VectorSupport_fromBitsCoerced) | ||
| { | ||
| TR::Node *broadcastTypeNode = node->getChild(4); |
There was a problem hiding this comment.
We have not done it before, but I think it would be nice to start using some class scope constants to define position of different parameters in the intrinsics, eg static int_32 const BROADCAST_TYPE_CHILD = 4 in the header.
There was a problem hiding this comment.
Agreed. Added the constant BROADCAST_TYPE_CHILD to the class and updated the code to use the constant.
| @@ -1810,7 +1830,8 @@ TR::Node *TR_VectorAPIExpansion::fromBitsCoercedIntrinsicHandler(TR_VectorAPIExp | |||
|
|
|||
| TR::Node *newNode; | |||
|
|
|||
| switch (elementType) { | |||
| int32_t type = mask ? TR::Int64 : elementType; | |||
| switch (type) { | |||
There was a problem hiding this comment.
Will we still generate vsplats? Maybe we need to introduce msplats?
There was a problem hiding this comment.
When broadcastType == MODE_BITS_COERCED_LONG_TO_MASK, opcode we generate is mLongBitsToMask. In that case, the source type of the conversion must be long instead of the element type.
There was a problem hiding this comment.
Oh, right, of course, we do generate the right opcode! Then everything looks good to me.
The return type of jdk_internal_vm_vector_VectorSupport_fromBitsCoerced can be either of Vector or Mask. Change the type field of the fromBitsCoerced entry in the method table to unknown and update visitNodeToBuildVectorAliases to get the correct type for the call by checking the value of the 5th child node. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
FixTypeOfFromBitsCoerced
branch
from
e6e02a3
to
a783df2
Compare
|
Jenkins test sanity all jdk8,jdk11,jdk19 |
The return type of
jdk_internal_vm_vector_VectorSupport_fromBitsCoercedcan be either of Vector or Mask.Change the type field of the
fromBitsCoercedentry in the method table tounknownand updatevisitNodeToBuildVectorAliasesto get the correct type for the call by checking the value of the 5th child node.Signed-off-by: Akira Saitoh saiaki@jp.ibm.com