-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITServer AOT cache testing #16366
JITServer AOT cache testing #16366
Conversation
7882912
to
5f520c2
Compare
561959e
to
c7a63a9
Compare
Grinder: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1530/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
We need to make sure that the AOT compilations come from the server and moreover from its AOT cache. One way to check that is to generate a verbose log and to look for "remote" and "deserialized" on the lines that denote compilation ends. |
49ee381
to
0779ebc
Compare
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
afcd840
to
1b9fe45
Compare
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
1b9fe45
to
ffd073f
Compare
369d90d
to
1061645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
jenkins test sanity zlinux jdk17 |
@ymanton Since this PR touches some of the code you originally wrote, could you please review it as well? Thanks |
The test fails because there are some |
1061645
to
368c83b
Compare
jenkins test sanity zlinux jdk17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
test/functional/JIT_Test/src/jit/test/jitserver/JITServerTest.java
Outdated
Show resolved
Hide resolved
The test failed on zLinux with
Strange that Linux on Z is not detected as an UNIX environment |
Also, I now think that |
I ran a grinder on xlinux and I found the same failure:
|
368c83b
to
b47bec3
Compare
jenkins test sanity zlinux jdk17 |
The test fails on zLinux with
I also realized that in testJITServer_2 all tests are executed with |
b47bec3
to
095f65f
Compare
The JITServer AOT cache is currently not covered by the tests. Additional tests are added in the JITServer test suite testJITServer. -The JITServer and the clients are run with an additional variation with JVM options for using shared class named test_jitscc and the AOT option JITServerUseAOTCache. -An additional test in the test suite does actions like destroying the cache, recreating it and reusing it. Closes: eclipse-openj9#15401 Signed-off-by:"SajinaKandy” <“sajina.kandy@ibm.com”>
095f65f
to
0e348cb
Compare
jenkins test sanity zlinux jdk17 |
The JITServer AOT cache is currently not covered by the tests. Additional tests are added in the JITServer test suite testJITServer.
-The JITServer and the clients are run with an additional variation with JVM options for using shared class named test_jitscc and the AOT option JITServerUseAOTCache.
-An additional test in the test suite does actions like destroying the cache, recreating it and reusing it.
Issue: #15401