Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in Java 8 build instructions #17329

Closed

Conversation

kgibm
Copy link
Contributor

@kgibm kgibm commented May 3, 2023

FreeType 2.5.3 has been moved to the freetype-old subfolder. Also changed to https.

@pshipton @keithc-ca

Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
@pshipton
Copy link
Member

pshipton commented May 3, 2023

Freetype is included in the jdk8 repo now, it doesn't need to be downloaded separately. We should fix the instructions to reflect that, although older versions would still need to download it.

@keithc-ca
Copy link
Contributor

keithc-ca commented May 3, 2023

Freetype is included in the jdk8 repo now, it doesn't need to be downloaded separately. We should fix the instructions to reflect that, although older versions would still need to download it.

Why would we keep parts of the instructions that no longer apply? If someone wants to build an older version, they should consult the instructions of the same vintage. I think we should just remove the advice to download freetype (for all platforms). As things stand, it advises that you download it, but the configure option that used to refer to where it was downloaded is no longer used (nor even available).

@pshipton pshipton self-requested a review May 3, 2023 19:18
@kgibm
Copy link
Contributor Author

kgibm commented May 4, 2023

Ok, maybe I'll just leave the removal of freetype to you all. I started searching all the build instructions for freetype and there are some things that I'm not sure if they should be removed or not (e.g. --with-freetype-include).

pshipton added a commit to pshipton/openj9 that referenced this pull request May 10, 2023
freetype is automatically include in jdk8 builds since
ibmruntimes/openj9-openjdk-jdk8#631

Obsoletes eclipse-openj9#17329

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member

pshipton commented May 10, 2023

Closing, obsoleted by #17379

@pshipton pshipton closed this May 10, 2023
midronij pushed a commit to midronij/openj9 that referenced this pull request May 24, 2023
freetype is automatically include in jdk8 builds since
ibmruntimes/openj9-openjdk-jdk8#631

Obsoletes eclipse-openj9#17329

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
midronij pushed a commit to midronij/openj9 that referenced this pull request Jun 1, 2023
freetype is automatically include in jdk8 builds since
ibmruntimes/openj9-openjdk-jdk8#631

Obsoletes eclipse-openj9#17329

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants