Restore OpenJ9DiagnosticsMXBean registration call in ManagementUtils #17726
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @keithc-ca @pshipton |
keithc-ca
requested changes
Jun 30, 2023
...src/java.management/share/classes/com/ibm/java/lang/management/internal/ManagementUtils.java
Outdated
Show resolved
Hide resolved
babsingh
force-pushed
the
support_HotSpotDiagnosticMXBean
branch
from
fd4edae to
99a761d
Compare
babsingh
changed the title
|
@babsingh while you are here, can you pls update the comment |
|
Please also change "add" back to "readd" (or to "restore") in the commit message and the description above to better reflect what this is about. |
babsingh
force-pushed
the
support_HotSpotDiagnosticMXBean
branch
from
99a761d to
67ca28f
Compare
babsingh
changed the title
babsingh
force-pushed
the
support_HotSpotDiagnosticMXBean
branch
2 times, most recently
from
04cea4e to
bd709aa
Compare
|
Added |
pshipton
approved these changes
Jun 30, 2023
keithc-ca
reviewed
Jun 30, 2023
...src/java.management/share/classes/com/ibm/java/lang/management/internal/ManagementUtils.java
Outdated
Show resolved
Hide resolved
keithc-ca
reviewed
Jun 30, 2023
...src/java.management/share/classes/com/ibm/java/lang/management/internal/ManagementUtils.java
Outdated
Show resolved
Hide resolved
babsingh
force-pushed
the
support_HotSpotDiagnosticMXBean
branch
from
bd709aa to
9c27aef
Compare
The registration call was removed in eclipse-openj9#17709 due to a false assumption. It has been added back since it is still required. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
support_HotSpotDiagnosticMXBean
branch
from
9c27aef to
cbb2e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration call was removed in #17709 due to a false
assumption. It has been added back since it is still required.
Refs: