CRIU moves CRIUSupport APIs from openj9.criu to java.base #18417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila Could you provide some feedback for this WIP PR? |
tajila
reviewed
Nov 8, 2023
test/functional/cmdLineTests/criu/src/org/openj9/criu/CRIUTestUtils.java
Outdated
Show resolved
Hide resolved
tajila
reviewed
Nov 8, 2023
JasonFengJ9
force-pushed
the
criuapis
branch
4 times, most recently
from
6db10d2
to
653f380
Compare
JasonFengJ9
force-pushed
the
criuapis
branch
2 times, most recently
from
a7e84b7
to
3c08255
Compare
|
@tajila This is ready for another look. |
tajila
reviewed
Nov 13, 2023
jcl/src/openj9.criu/share/classes/org/eclipse/openj9/criu/CRIUSupport.java
Show resolved
Hide resolved
JasonFengJ9
force-pushed
the
criuapis
branch
from
3c08255
to
c69f383
Compare
The CRIUSupport.checkpointJVM() can be invoked within java.base; Moved openj9.criu/org.eclipse.openj9.criu.CRIUSupport checkpointJVM related implementation into java.base/openj9.internal.criu.InternalCRIUSupport, CRIUSupport APIs are just wrappers of InternalCRIUSupport methods; Moved J9InternalCheckpointHookAPI & SecurityProviders as well; Duplicated CRIUDumpPermission & CRIU exception classes within openj9.internal.criu; Moved criusupport.cpp/hpp contents into CRIUHelpers.cpp & criu.cpp; Updated the class references and tests. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
criuapis
branch
from
c69f383
to
c1dce9e
Compare
|
Rebased to resolve the merging conflict. |
|
jenkins test sanity zlinux jdk11 |
|
jenkins test sanity alinx64 jdk17 |
|
jenkins test sanity zlinux jdk21 |
|
jenkins test sanity alinux64 jdk17 |
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIUmovesCRIUSupportAPIs fromopenj9.criutojava.baseThe
CRIUSupport.checkpointJVM()can be invoked withinjava.base;Moved
openj9.criu/org.eclipse.openj9.criu.CRIUSupportcheckpointJVMrelated implementation intojava.base/openj9.internal.criu.InternalCRIUSupport,CRIUSupportAPIs are just wrappers ofInternalCRIUSupportmethods;Moved
J9InternalCheckpointHookAPI&SecurityProvidersas well;Duplicated
CRIUDumpPermission&CRIUexception classes withinopenj9.internal.criu;Moved
criusupport.cpp/hppcontents intoCRIUHelpers.cpp&criu.cpp;Updated the class references and tests.
Signed-off-by: Jason Feng fengj@ca.ibm.com