Re-fetch objects after VM access is released and reacquired #18420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stale objects can manifest many issues. In this case, stale objects cause complex and intermittent synchronization issues. Related: eclipse-openj9#17865 Related: eclipse-openj9#17869 Related: eclipse-openj9#18370 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
requested review from
tajila and
gacholio
and removed request for
tajila
gacholio
approved these changes
Nov 8, 2023
|
I looked at |
|
jenkins test sanity zlinux jdk21 |
Yes, VM is always entered prior to invoking acquireVThreadInspector. I will update it to release and acquire VM access in a new PR. |
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
Nov 9, 2023
VM is entered by the invocation of internalEnterVMFromJNI. VM is exited by the invocation of internalExitVMToJNI VM is always entered before acquireVThreadInspector and enterVThreadTransitionCritical are invoked. In these functions, the goal can be achieved by just releasing and re-acquiring VM access. The new changes just release and re-acquire VM access instead of exiting and entering the VM. This has less overhead. Addresses: eclipse-openj9#18420 (comment) Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
Nov 9, 2023
VM is entered by the invocation of internalEnterVMFromJNI. VM is exited by the invocation of internalExitVMToJNI. VM is always entered before acquireVThreadInspector and enterVThreadTransitionCritical are invoked. In these functions, the goal can be achieved by just releasing and re-acquiring VM access. The new changes just release and re-acquire VM access instead of exiting and entering the VM. This has less overhead. Addresses: eclipse-openj9#18420 (comment) Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stale objects can manifest many issues. In this case, stale objects
cause complex and intermittent synchronization issues.
Related: #17865
Related: #17869
Related: #18370