Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRIU adds jdk.crac APIs #18627

Merged
merged 1 commit into from
Jan 24, 2024
Merged

CRIU adds jdk.crac APIs #18627

merged 1 commit into from
Jan 24, 2024

Conversation

JasonFengJ9
Copy link
Member

@JasonFengJ9 JasonFengJ9 commented Dec 14, 2023 •
edited
Loading

CRIU adds jdk.crac APIs

Added jdk.crac.CheckpointException/RestoreException;
Added jdk.crac.Context/Resource;
Added jdk.crac.Core;
Added a new flag J9VM_CRAC_IS_CHECKPOINT_ENABLED;
Added a test with a new feature CRAC.

Co-authored with Tobi Ajila atobia@ca.ibm.com
Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 marked this pull request as draft December 14, 2023 14:21
@JasonFengJ9 JasonFengJ9 added comp:vm criu Used to track CRIU snapshot related work labels Dec 14, 2023
@JasonFengJ9
Copy link
Member Author

@tajila Could you please review this draft PR?

@JasonFengJ9
Copy link
Member Author

Was interrupted by another item and the vacation.

@tajila this is ready for another look.

@JasonFengJ9 JasonFengJ9 force-pushed the jdkcracapis branch 2 times, most recently from d54b03e to 6d06eb6 Compare January 5, 2024 22:45
tajila
tajila reviewed Jan 8, 2024
View reviewed changes
runtime/vm/jvminit.c Outdated Show resolved Hide resolved
@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 9, 2024
Merged
@JasonFengJ9 JasonFengJ9 mentioned this pull request Jan 18, 2024
Merged
@JasonFengJ9 JasonFengJ9 marked this pull request as ready for review January 22, 2024 12:54
@tajila
Copy link
Contributor

tajila commented Jan 23, 2024

@dsouzai Please review JIT changes

dsouzai
dsouzai approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT changes lgtm

tajila
tajila reviewed Jan 23, 2024
View reviewed changes
runtime/nls/j9vm/j9vm.nls Outdated Show resolved Hide resolved
tajila
tajila reviewed Jan 23, 2024
View reviewed changes
runtime/jcl/common/criu.cpp Outdated Show resolved Hide resolved
tajila
tajila approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@tajila tajila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@JasonFengJ9
CRIU adds jdk.crac APIs
ed1029b 
Added jdk.crac.CheckpointException/RestoreException;
Added jdk.crac.Context/Resource;
Added jdk.crac.Core;
Added a new flag J9VM_CRAC_IS_CHECKPOINT_ENABLED;
Added a test with a new feature CRAC.

Co-authored with Tobi Ajila <atobia@ca.ibm.com>
Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@tajila
Copy link
Contributor

tajila commented Jan 24, 2024

jenkins test sanity plinux jdk21

@tajila
Copy link
Contributor

tajila commented Jan 24, 2024

jenkins test sanity win jdk8

@tajila tajila merged commit ffac7ff into eclipse-openj9:master Jan 24, 2024
7 checks passed
@keithc-ca keithc-ca mentioned this pull request Jan 24, 2024
Merged
@keithc-ca
Copy link
Contributor

keithc-ca commented Jan 24, 2024 •
edited
Loading

I think the build failure in https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_linux_Personal_testList_0/33/console is due to this change.

@JasonFengJ9
Copy link
Member Author

I think the build failure in https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_linux_Personal_testList_0/33/console is due to this change.

As we discussed offline, the PR build seems to only have the test part of this change.

@keithc-ca keithc-ca mentioned this pull request Jan 24, 2024
Merged
@JasonFengJ9 JasonFengJ9 deleted the jdkcracapis branch January 24, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca left review comments

@tajila tajila tajila approved these changes

@dsouzai dsouzai dsouzai approved these changes

Assignees
No one assigned
Labels
comp:vm criu Used to track CRIU snapshot related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonFengJ9 @tajila @keithc-ca @dsouzai