-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the new changes to the VirtualThread states #18673
Conversation
RUNNABLE=2 state was removed, and all other states are re-numbered due to the removal of the RUNNABLE state. Two new states are added: UNPARKED=9 and YIELDED=11. Currently, VirtualThread.yield incorrectly consumes the parking permit. The parking permit should only be consumed when continuing from VirtualThread.park. The two new states are added to address this incorrect behaviour. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This is to support the fix for https://bugs.openjdk.org/browse/JDK-8321270. The fix is currently in JDK22 and JDK23 (JDK-next). The fix will eventually be ported to JDK21 as per https://bugs.openjdk.org/browse/JDK-8321270. Commit title -- This PR doesn't have ifdefs for JDK22+. So, this PR shouldn't be merged until the fix is ported to JDK21. ibmruntimes/openj9-openjdk-jdk21#103 backports the fix to JDK21. To avoid any side-effects from JDK-8321270's fix, the backport can wait until the 0.42 and 0.43 targets are released. If JDK-8321270's fix is ported by the RI to JDK21, then we can just merge this PR and close ibmruntimes/openj9-openjdk-jdk21#103. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jenkins test sanity.functional,sanity.openjdk aix jdk21 depends ibmruntimes/openj9-openjdk-jdk21#103 |
Does this really matter ? 0.42 and 0.43 have already branched. |
It does make it easier to merge 21.0.2 to 0.43, and any other fixes in the extensions for 0.42/0.43 (and we do need one). I won't merge it now. I've added it to the 0.43 milestone just in case JDK-8321270 shows up in 21.0.2. |
We should show caution with these changes. Before merging, we should also run the |
Jenkins test extended.openjdk aix jdk21 depends ibmruntimes/openj9-openjdk-jdk21#103 |
Jenkins test extended.openjdk alinux jdk21 depends ibmruntimes/openj9-openjdk-jdk21#103 |
Does 21.0.2 have the JDK-8321270 fix ? |
I see this is moved to Release 0.44, so I guess the answer is no. |
Yes, @pshipton plans to merge it in a few days after monitoring the new extension repo changes. |
OK, I'll let Peter merge this. |
RUNNABLE=2
state was removed, and all other states are re-numbereddue to the removal of the
RUNNABLE
state.Two new states are added:
UNPARKED=9
andYIELDED=11
.Currently,
VirtualThread.yield
incorrectly consumes the parkingpermit. The parking permit should only be consumed when continuing
from
VirtualThread.park
. The two new states are added to addressthis incorrect behaviour.
Depends on ibmruntimes/openj9-openjdk-jdk21#103