[FFI/v0.45.0] Handle the discontiguous heap array in downcall #19306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes aim to address the case of discontiguous heap array in the critical downcall by copying the heap array to a native memory given the passed-in array in the native function must be a contiguous one for native access. Related: eclipse-openj9#17872 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Add declarations in vm_internal.h so they can be used in ArrayCopyHelpers.cpp. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Reviewer: @pshipton |
pshipton
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes aim to address the case of discontiguous heap
array in the critical downcall by copying the heap array
to a native memory given the passed-in array in the native
function must be a contiguous one for native access.
Related: #17872
Port of #19263 for 0.45
Signed-off-by: ChengJin01 jincheng@ca.ibm.com