Fall back to out-of-line call to StringUTF16.toBytes #19953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of StringUTF16.toBytes will throw a NegativeArraySizeException if the specified array length is negative or an OutOfMemoryError if the length is 2^30 or greater. The IL for the inline implementation that the JIT compiler generates for that recognized method could throw a NegativeArraySizeException in situations where the actual implementation would throw an OutOfMemoryError. This change calls the actual implementation if the array length is outside the range [0,0x3fffffff] to ensure that the expected behaviour always results in exceptional situations. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
@knn-k, may I ask you to review this change? |
knn-k
reviewed
Aug 2, 2024
|
I looked through the commit. It looked OK to me, but I am not familiar with manipulation of IL trees. I would like someone else to review. |
This change corrects some typographical errors in the use of "fallback" and "fall back." When used as a noun, the correct word is fallback. When used as a verb, it should be written "fall back"; when used as a noun, the word is "fallback." Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
@0xdaryl, may I ask you to review this change as well? Once changes have been approved, I will squash the commit that corrects the typos. |
|
@0xdaryl, may I ask you to review this change? |
|
Jenkins test sanity all jdk21 |
|
The Z JitServer failure has been seen before, and I don't think has anything to do with this PR. No nodes are available for the Windows build. |
0xdaryl
approved these changes
Aug 19, 2024
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
StringUTF16.toByteswill throw aNegativeArraySizeExceptionif the specified array length is negative or anOutOfMemoryErrorif the length is 2^30 or greater. The IL for the inline implementation that the JIT compiler generates for that recognized method could throw aNegativeArraySizeExceptionin situations where the actual implementation would throw anOutOfMemoryError.This change calls the actual implementation if the array length is outside the range [0,0x3fffffff] to ensure that the behaviour is always as expected in exceptional situations.
Fixes #19309