-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark TR_J9VMServer virtual methods with override #20376
Conversation
The isIndexableDataAdrPresent() and isOffHeapAlocationEnabled() methods override the TR_J9VMBase implementations. They are now marked with override; a compilation error results without it with clang in the default configuration (with -Werror). Signed-off-by: Christian Despres <despresc@ibm.com>
Attn @mpirvu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins test sanity zlinuxjit,xlinuxjit jdk17 |
xlinuxjit had a timeout on jdk_util_0
|
The xlinuxjit failure was in I don't think the |
I agree that the changes in this PR are very unlikely to cause the issues seen in testing. |
The isIndexableDataAdrPresent() and isOffHeapAlocationEnabled() methods override the TR_J9VMBase implementations. They are now marked with override; a compilation error results without it with clang in the default configuration (with -Werror).