Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark TR_J9VMServer virtual methods with override #20376

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

cjjdespres
Copy link
Contributor

The isIndexableDataAdrPresent() and isOffHeapAlocationEnabled() methods override the TR_J9VMBase implementations. They are now marked with override; a compilation error results without it with clang in the default configuration (with -Werror).

The isIndexableDataAdrPresent() and isOffHeapAlocationEnabled() methods
override the TR_J9VMBase implementations. They are now marked with
override; a compilation error results without it with clang in the
default configuration (with -Werror).

Signed-off-by: Christian Despres <despresc@ibm.com>
@cjjdespres cjjdespres requested a review from dsouzai as a code owner October 17, 2024 16:55
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu

@mpirvu mpirvu self-assigned this Oct 19, 2024
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Oct 19, 2024
@mpirvu
Copy link
Contributor

mpirvu commented Oct 19, 2024

jenkins test sanity zlinuxjit,xlinuxjit jdk17

@mpirvu
Copy link
Contributor

mpirvu commented Oct 21, 2024

xlinuxjit had a timeout on jdk_util_0
zlinuxjit had a test assert failure on the same test

jdk_util_0 Start Time: Sat Oct 19 20:19:55 2024 Epoch Time (ms): 1729383595298
20:19:55  variation: -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache Mode150
20:19:55  JVM_OPTIONS: -XX:+UseJITServer -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -XX:+UseCompressedOops -Xverbosegclog 
............
20:30:32  ACTION: main -- Failed. Execution failed: `main' threw exception: java.lang.AssertionError: Some tests failed
20:30:32  REASON: Assumed action based on file name: run main DeflateIn_InflateOut 

@cjjdespres
Copy link
Contributor Author

The xlinuxjit failure was in CountLargeTest, which has had timeouts in the past (#15198), including one that was JITServer-specific (#17971, on aarch64). The zlinuxjit failure in DeflateIn_InflateOut I haven't seen before. Unfortunately, that latter test component is one of those that merely reports its overall success or failure in the logs without other detail. I can double-check the nightly tests to see if either has occurred there.

I don't think the override specifier addition is responsible - I'm fairly sure that it just asserts that the virtual method does in fact override something, and doesn't influence anything else.

@mpirvu
Copy link
Contributor

mpirvu commented Oct 22, 2024

I agree that the changes in this PR are very unlikely to cause the issues seen in testing.

@mpirvu mpirvu merged commit 636d4a0 into eclipse-openj9:master Oct 22, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants