WIP: Replace MemberName class with OpenJDK implementation #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: First 9 commits are picked from #7625 and should be removed from this PR once the it is delivered. Also, the native method headers added in MethodHandleNatives are for compilation requirements (VM compiles & passes simple testcases), there may still be patchings required to enable the actual functionality in VM native code. |
11 tasks
fengxue-IS
force-pushed
the
replaceMN
branch
4 times, most recently
from
54466e9
to
c99368a
Compare
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- MT.returnType -> MT.returnType() - MT.arguments -> MT.ptypes() - MT.argSlots -> MT.parameterSlotCount() - MT.dropFirstParameterType -> MT.dropParameterTypes(0,1) - MT.getInvokeExactHandle() -> MT.invokers().exactInvoker() Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Name changes: - MT.arguments -> MT.ptypes - MT.returnType -> MT.rtype - MT.vmResolveFromMethodDescriptorString -> MTHelper.vmResolveFromMethodDescriptorString New refs: - MethodTypeHelper.class - MethodTypeForm.class - MethodType.form - MethodTypeForm.argCounts Removed: - MethodType.stackDescriptionBits - MethodType.argSlots Replaced with parameterSlotCount() API Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- Update field name to OpenJDK name - Remove METHODTYPE_STACKDESCRIPTIONBITS - Add VMHelpers::getArgSlotFromMethodType API to replaces J9VMJAVALANGINVOKEMETHODTYPE_ARGSLOTS marco Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- generate stackbits using MT.ptypes Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- init a new MemberName object with null class ref Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
- Fix MethodHandleNatives native method header for Java8 Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
fengxue-IS
force-pushed
the
replaceMN
branch
2 times, most recently
from
ec55934
to
a0090c6
Compare
|
@fengxue-IS @babsingh is this still relevant? |
|
Closing this PR as it is no longer relevent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #7352
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com