Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Remove EJML (v0.29) bundles from Orbit #19

Closed
eselmeister opened this issue May 10, 2023 · 4 comments · Fixed by #24
Closed

Remove EJML (v0.29) bundles from Orbit #19

eselmeister opened this issue May 10, 2023 · 4 comments · Fixed by #24

Comments

@eselmeister
Copy link
Contributor

A newer version (v0.43) is available here:
http://ejml.org

Furthermore, we faced some problems with conflicting classes when consuming EJML via Orbit. Nowadays, it works fine to reference the EJML dependencies in the product definition by using the Maven dependency option.

If no one else has objections, I will remove the bundles soon.

@jonahgraham
Copy link
Contributor

If no one else has objections, I will remove the bundles soon.

No objection - please go ahead.

Nowadays, it works fine to reference the EJML dependencies in the product definition by using the Maven dependency option.

As EJML doesn't seem to have OSGi headers, do you need to coordinate with others to make sure that the OSGi headers match. From a SimRel perspective it doesn't matter as I don't think you contribute EJML to SimRel.

@merks
Copy link
Contributor

merks commented May 10, 2023

This seems to have bundle information:

https://repo1.maven.org/maven2/org/ejml/core/0.30/

You're not needing to generate OSGi metadata for any of these things?

@jonahgraham
Copy link
Contributor

0.43 doesn't seem to have OSGi here https://repo1.maven.org/maven2/org/ejml/ejml-core/0.43/ - I think they changed artifact Id in 0.31 - https://github.com/lessthanoptimal/ejml/blob/v0.43/change.txt#L419 and the OSGi headers left in 0.39 (side effect of https://github.com/lessthanoptimal/ejml/blob/v0.43/change.txt#L154 as commit lessthanoptimal/ejml@011e9bb says "- Removed OSGI")

@eselmeister perhaps it is raising an issue with EJML to reenable the headers?

@eselmeister
Copy link
Contributor Author

Yep, we could ask him to do that. I would have to inspect my previous integration of EJML again, but I faintly remember, that there were problems with conflicting imports when using OSGi. Let me have a look at my documents for a detailed answer.

eselmeister added a commit that referenced this issue Jun 27, 2023
When using the EJML bundles from Orbit, it could cause problems regarding the class path, as packages contain the same name.
#19

Meanwhile, EJML v0.43 is available:
https://github.com/lessthanoptimal/ejml/releases/tag/v0.43

It could be more consistently fetched via the Maven/Target artifacts approach.
jonahgraham pushed a commit that referenced this issue Jun 29, 2023
When using the EJML bundles from Orbit, it could cause problems regarding the class path, as packages contain the same name.
#19

Meanwhile, EJML v0.43 is available:
https://github.com/lessthanoptimal/ejml/releases/tag/v0.43

It could be more consistently fetched via the Maven/Target artifacts approach.

Fixes #19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants