Impl #44 - Add CRaC support #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fipro78, LGTM. The resource is hard-referenced, the code for jetty is aligned with our examples (I'm not an expert there), so overall looks good. Thank you! |
juergen-albert
force-pushed
the
main
branch
from
215e748
to
dd15b4a
Compare
fipro78
force-pushed
the
main
branch
2 times, most recently
from
339c8ae
to
57c197a
Compare
|
As discussed with @tjwatson and @stbischof I updated the PR to make the org.crac API optional at runtime. I successfully tested:
All cases work as expected. The failures in the checks seem to be not related to my work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CRaC support to the jetty bundle by using the
org.cracAPI.It adapts
@AntonKozlov
Could you also have a look and provide some comment, if my assumption that the usage of
org.cracAPI is without a risk here?