Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/foreground service #418

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MGasztold
Copy link

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • [ X] You have signed the Eclipse ECA
  • [ X] All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
  • [ X] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
  • [ X] If this is new functionality, You have added the appropriate Unit tests.

This pull requests solves issues with Android versions >=8 in which service is killed by OS when app is in background or after screen is turned off. The price to pay for this is the notification that has to be permanently visible in the app's status bar.

The API I proposed let's developer start MQTT service as foreground service and provide its own Notification object. In the same time it is totally optional.

I also got rid of legacy support library dependency in favor of latest androidx dependency.

This pull requests tries to solve the following issues:
#416 #332 #281 #274 #226

Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
Signed-off-by: MGasztold <michal.gasztold@ubudu.com>
@alexwijoyo
Copy link

Hi, what is the status of this pull request? I need the foreground service capabilities. Thanks.

@MGasztold
Copy link
Author

@alexwijoyo Hello, I am successfully using it in my project. I do not know what is left
for it to be merged to develop. Probably it awaits a review from somebody
with the rights to eventually apply it.

@edu1525
Copy link

edu1525 commented Oct 20, 2020

Hello, I really need this pull request in my project, I'm having some problems with foreground services.

@MGasztold
Copy link
Author

Anybody knows whose attention should I get in order to make this pull request be merged?

@alexwijoyo
Copy link

@MGasztold I will try to incorporate your fork library source to my project. Thanks.

Afflya pushed a commit to Afflya/paho.mqtt.android that referenced this pull request Oct 30, 2020
Signed-off-by: chowen <chowen.dev@gmail.com>
Afflya pushed a commit to Afflya/paho.mqtt.android that referenced this pull request Oct 30, 2020
@thanksmister
Copy link

Is this going to get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants