Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect return value from SSLSocket_createContext() #1005

Closed
wants to merge 1 commit into from

Conversation

sasq64
Copy link

@sasq64 sasq64 commented Nov 27, 2020

Fix incorrect return value from SSLSocket_createContext() using the protos field.

(I am not signing the ECA so I guess this PR is informative only)

@a4z
Copy link

a4z commented Dec 8, 2020

Hi @icraggs , what are you say to this PR?

It seems @sasq64 is one of the user who do not want to have some steps like the eca in their PR , but it also seem I need exactly that fix for a current project.

can you pull that in, or would it help if I submit the same PR , since I have a eca ?

@icraggs icraggs added this to the 1.3.8 milestone Dec 8, 2020
@icraggs
Copy link
Contributor

icraggs commented Dec 8, 2020

I'll add the changes.

@a4z
Copy link

a4z commented Dec 8, 2020

awesome, thanks a lot Ian!

@icraggs
Copy link
Contributor

icraggs commented Dec 10, 2020

Added in referenced commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL_CTX_set_alpn_protos call breaks SSLSocket_createContext return value
3 participants