Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timeout of send thread in Async client for v5 #1457

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix timeout of send thread in Async client for v5 #1457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11757bf
Fix timeout of send thread in Async client for v5
TiejunMS Mar 5, 2024
54786b6
Fix the same issue to PUBCOMP as suggested by @icraggs
TiejunMS Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/MQTTAsyncUtils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3074,11 +3074,27 @@ static MQTTPacket* MQTTAsync_cycle(SOCKET* sock, unsigned long timeout, int* rc)
}

if (msgtype == PUBCOMP)
{
*rc = MQTTProtocol_handlePubcomps(pack, *sock, &pubToRemove);
if (sendThread_state != STOPPED)
#if !defined(_WIN32) && !defined(_WIN64)
Thread_signal_cond(send_cond);
#else
Thread_post_sem(send_sem);
#endif
}
else if (msgtype == PUBREC)
*rc = MQTTProtocol_handlePubrecs(pack, *sock, &pubToRemove);
else if (msgtype == PUBACK)
{
*rc = MQTTProtocol_handlePubacks(pack, *sock, &pubToRemove);
if (sendThread_state != STOPPED)
#if !defined(_WIN32) && !defined(_WIN64)
Thread_signal_cond(send_cond);
#else
Thread_post_sem(send_sem);
#endif
}
if (!m)
Log(LOG_ERROR, -1, "PUBCOMP, PUBACK or PUBREC received for no client, msgid %d", msgid);
if (m && (msgtype != PUBREC || ackrc >= MQTTREASONCODE_UNSPECIFIED_ERROR))
Expand Down