Fix StackOverflow in MQTTv5 MqttClient and resulting IOOBE in MqttAsyncClient #887
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[✓] This change is against the develop branch, not master.
[ ✓] You have signed the Eclipse ECA
[ ✓] All of your commits have been signed-off with the correct email address (the same one that you
used to sign the CLA) Hint: use the -s argument when committing.
[✓ ] If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that
you are fixing straight away that you add some Description about the bug and how this will fix it.
If this is new functionality, You have added the appropriate Unit tests.
Fixes:
StackOverflow in MQTTv5 when subscribing with a topicfilter, qos and a IMqttMessageListener #863
The subscribe method is calling itself.