Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where Recursively calling the same method causes StackOverFlow #899

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

BaekSeungYeol
Copy link
Contributor

@BaekSeungYeol BaekSeungYeol commented Oct 14, 2021

  • This change is against the develop branch, not master.
  • You have signed the Eclipse ECA
  • All of your commits have been signed-off with the correct email address (the same one that you
    used to sign the CLA) Hint: use the -s argument when committing.
  • If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that
  • you are fixing straight away that you add some Description about the bug and how this will fix it.
    If this is new functionality, You have added the appropriate Unit tests.

image

Existing code was calling the same method over and over again. and it causes StackOverFlow.

@cook-coder
Copy link

Nice try, bro. I found this bug, too.

@shurkanTwo
Copy link

When will this PR be merged? We are facing this issue and therefore can not use the paho mqtt v5 client.

@rdasgupt rdasgupt merged commit e845497 into eclipse-paho:develop Aug 6, 2022
@cseewald
Copy link

If you do not want to use a snapshot release to get the fix for this bug, you can also use
org.eclipse.paho.mqttv5.client.MqttClient#subscribe(org.eclipse.paho.mqttv5.common.MqttSubscription[], org.eclipse.paho.mqttv5.client.IMqttMessageListener[]) instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants