Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable editing of draft submissions #905

Closed
jabrah opened this issue Apr 18, 2019 · 1 comment · Fixed by #941
Closed

Re-enable editing of draft submissions #905

jabrah opened this issue Apr 18, 2019 · 1 comment · Fixed by #941
Assignees
Labels
Configuration MF medium unfamiliar issues to local skills set

Comments

@jabrah
Copy link
Contributor

jabrah commented Apr 18, 2019

A few things need to happen before this will be done:

  • Journal service integrated : this is needed because it will overhaul the handling of DOI data and how various related objects are created/handled in the submission workflow
  • Publication object is created and persisted in the workflow-basics step. The publication object is currently created in the submissions/new route, technically outside of the workflow steps. It is currently not persisted until the submission is finally submitted in the review step.
    • This is supported already by doi#createPublication() but needs to be integrated along with the Journal service work

Completing this will enable the Edit button in the submissions table and submission details page. It will also allow draft submissions to display correctly in the submissions table, since there will actually be a title to show.

@jabrah
Copy link
Contributor Author

jabrah commented May 29, 2019

We also need to track attached files, assuming a user moves through the submission workflow, attaches one or more files, and leaves the submission workflow.

A few things need to happen to support this. The most straightforward way:

  • Autosave function in the files step should upload/persist the File objects
    • This suggests that file upload no longer needs to happen during the review step
  • File objects are deleted when submissions are deleted or aborted
  • Files objects are correctly loaded into the workflow service when a draft submission is loaded into the submission workflow (for editing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration MF medium unfamiliar issues to local skills set
Projects
None yet
2 participants