-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable draft edit #941
Reenable draft edit #941
Conversation
I made a few cleanups and fixes. Looks good to me now. |
Files are not yet persisted in a Draft submission yet. This means that if a user uploads a file (and clicks Next to get to the Review step), but then leaves the workflow, when they go to edit the submission, the file will no longer be attached to the submission. The user will have to re-add the file(s). Workflow should be modified to persist the File objects when the submission is auto-saved (currently happens when the user transitions between steps). |
345d220
to
cec3500
Compare
Closes #905
Reopening this PR from the
pass-ember
repo, instead of from my fork so that other people can make changes.Only limited tests so far.
My biggest concern is the way Journal data is loaded in the case of a draft submission with a Publication with no DOI. This is handled similarly to how DOI would be loaded into the widget: if applicable, it will send the
selectJournal
action to kick off it's logic and add the Journal metadata to the workflow service. Applicability here is if a Journal object is passed to the component from thesubmission/new
route, which should happen only when loading draft submissions.Changes