-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding server-side pagination support #1243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could introduce an RSQL library if we wanted to abstract the RSQL query generation better |
jaredgalanis
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Will) Close eclipse-pass/main#547
Changes
Description
Adding support for server-side pagination, where previously we grabbed all records and did client side paging. For now, I've added some URL query params:
page
[integer] : current page to showpageSize
[integer] : number of items per pagefilter
[string] : global search string to narrow items shown on the pagegrant.projectName
These query params will be automatically added to the URL and updated as the user uses the pagination controls, but the user can also manually update these parameters in their address bar, if desired
TODO
[ ] Add pagination to the grant selector in the submission workflow[ ] Debounce requests as needed for the above implementationsNeed to see about separating debounce of pagination params vs filter (out-of-the-box they are handled with the same mechanism)_loadDataOnce
which handles debouncing via the Ember runloop. Default is 500msQuestions
page=20
when there's only 1 page of results from the backend?Testing
Manual
You can check any of the above sections. Using pagination controls will update URL query parameters on the page.
Since we don't have a huge amount of test data, you can manually set page size to something small, like
pageSize=2
to force the results to render across multiple pages