-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages/bundles that are already imported/added are shown #1195
base: master
Are you sure you want to change the base?
Packages/bundles that are already imported/added are shown #1195
Conversation
@lathapatil - did change set from #1194 carry over into this PR? |
No, I am trying to figure out what went wrong. Looks like #1194 has not reached here along with its branch ! |
it is probably because you branched out for this PR from the previous branch, so the tip of the branch got carried over. nothing to worry: I will help you fix that. if you are using command line then do this:
|
6d51a60
to
f0da0ed
Compare
Yes. Thanks for the support . |
@laeubi Could you please test the PR if it meets the expectations and possibly review the code ? |
@lathapatil do I need to consider something special? I fetched this PR then started an embedded workbench and tried the following: but package I also think it would be good to have a checkbox (enabled by default) "Show already imported packages", at best the user choice is persisted to survive a restart. |
After checking out the pull request (PR) while in PDE workspace , switch to the PR branch and launch the Eclipse application. Then, create a plugin project and inspect the manifest file for imported packages, required bundles, and exported packages. This is what I have attempted, and the changes are visible. What do you mean by embedded workbench ? |
This is already part of the PR. But I observed there is some delay in loading all packages |
Please find attached video for working of the feature from the branch https://github.com/lathapatil/eclipse.pde/tree/Issues/146_Show_imported_exported_required_bundles 2024-04-09_15h43_11.mp4 |
…ted_required_bundles
@laeubi could you please try testing and reviewing this ? |
@lathapatil - sure, will do. also, could you pls rebase your changes? as it was quite some time, now there is a conflict that has emerged. |
Packages/bundles that are already imported/added are shown followed by [already imported/added]
Fixes #146