Comparator Errors in 4.32 I-Build: I20240320-0740 #1923
Comments
3 tasks
|
Waiting on checking if all the changes are expected, see: eclipse-jdt/eclipse.jdt.core#2171 (comment) Output from running |
|
Note: many bundles didn't changed their version in 4.32 release yet. For such bundles one should only bump third version segment in manifest and with that one can skip "forceQualifierUpdate" change. |
|
Please also release new ECJ and update the version in the parent pom as otherwise all verification builds will show comparator warnings. |
@jarthana - please could you look into this and confirm that this has been take care of ? |
|
Sorry I have been updating on the wrong ticket. Will carry over relevant comments to here. |
|
Good morning gentlemen, The build looks good from tests p.o.v. I inspected the tests that fail on all 5 platforms and we have only this one new: (We also have eclipse-jdt/eclipse.jdt.core#2187 - don't know yet why this didn't fail in I-build) |
Except for these errors - which I think are due to excessively long path names - the unzip went fine
`$ find 2>/tmp/err . -name '*.class-baseline' > baseline-classes $ cat /tmp/err #### To verify no errors - yes no errors. $ head baseline-classes $ wc -l baseline-classes So, OK we got
The accumulated text diffs look like this:$head -30 classfile-diff.out Now the job is to verify that only stack depth changes are encountered in this file. Anything else needs scruitiny |
|
I have mechanically verified that the textual diffs contains only stack size reductions. The one lone exception is called out below. Now corelating the stacksize reductions to indy instructions count is not undertaken for the full set of The exception is (1) this diff below that needs to be studied. (2) the unzip errors: these class files would have to be analyzed somehow: I'll continue. |
Configured , Please Run to deploy new ECJ version (https://ci.eclipse.org/jdt/job/copyAndDeployJDTCompiler/) and merge PR #1925 |
|
Update: By unzipping the artifacts on Linux I was able to avoid the unzip I/O errors I had mentioned earlier. The set of files that couldn't be extracted earlier could now be and are found to have only stack size changes. The difference in The differing chunks cited above and reproduced below: are actually originating from Summary: I don't see any real issues with the comparator errors in this build and we can move forward and mark the build as stable and take the steps to update/touch bundles as needed. FYI - @iloveeclipse @laeubi @trancexpress @jarthana @sravanlakkimsetti - Thanks for all the help and discussions. |
|
Alright, thank you @srikanth-sankaran ! I've started looking into what changes need to be made, and will start setting PRs soon. |
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform.releng.aggregator
that referenced
this issue
Mar 21, 2024
|
@trancexpress : I've updated TouchBundles tool to automatically bump bundle versions if needed, see #1931. This should greatly simplify manual efforts needed to check & update bundle versions for bundles which didn't changed version in the current release yet. |
|
PS: I haven't tried to run it yet on entire repo, as I'm only tested on Windows where I can't extract current artifact comparisons zip, but functionality to update versions if needed should work. |
7Zip should be able to extract archives with long names. |
I wrote a script to bump bundle versions, if bundles were not updated since 4.32 stream was created (I assume this was 5th of March, 2024), just bump version and don't make a change in the txt file. Is this logic correct or did I misunderstand your earlier comment? #1923 (comment) Honestly it would be more simple to just include the txt files too, in the change. We are anyway bumping manifest versions and so changing the bundles. |
The logic shouldn't be based on timestamps but on git tag, as master opens before release happens. If you have the script, fine, I just wanted to automate the work for the future, not only for current build. |
OK, I'll try using the updated |
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform.releng.aggregator
that referenced
this issue
Mar 21, 2024
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform.releng.aggregator
that referenced
this issue
Mar 21, 2024
trancexpress
added a commit
to trancexpress/eclipse.platform.ui
that referenced
this issue
Mar 21, 2024
trancexpress
added a commit
to trancexpress/eclipse.platform.releng.aggregator
that referenced
this issue
Mar 21, 2024
This was referenced Mar 21, 2024
trancexpress
added a commit
to trancexpress/eclipse.platform.releng.aggregator
that referenced
this issue
Mar 21, 2024
trancexpress
added a commit
to trancexpress/eclipse.jdt.ui
that referenced
this issue
Mar 21, 2024
Wittmaxi
pushed a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this issue
Mar 21, 2024
In response to issue eclipse-platform#1090. Goals for this overlay are a simple and modern UI/UX for finding/replacing in eclipse. Updated bundles with comparator errors See: eclipse-platform/eclipse.platform.releng.aggregator#1923 Implemented Find-Replace Overlay. In response to issue eclipse-platform#1090. Goals for this overlay are a simple and modern UI/UX for finding/replacing in eclipse. Updated bundles with comparator errors See: eclipse-platform/eclipse.platform.releng.aggregator#1923
Wittmaxi
pushed a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this issue
Mar 21, 2024
In response to issue eclipse-platform#1090. Goals for this overlay are a simple and modern UI/UX for finding/replacing in eclipse. Updated bundles with comparator errors See: eclipse-platform/eclipse.platform.releng.aggregator#1923 Implemented Find-Replace Overlay. In response to issue eclipse-platform#1090. Goals for this overlay are a simple and modern UI/UX for finding/replacing in eclipse. Updated bundles with comparator errors See: eclipse-platform/eclipse.platform.releng.aggregator#1923
iloveeclipse
pushed a commit
to eclipse-jdt/eclipse.jdt.ui
that referenced
this issue
Mar 21, 2024
iloveeclipse
pushed a commit
that referenced
this issue
Mar 21, 2024
iloveeclipse
pushed a commit
to eclipse-equinox/equinox
that referenced
this issue
Mar 21, 2024
iloveeclipse
pushed a commit
to eclipse-equinox/p2
that referenced
this issue
Mar 21, 2024
|
I've triggered new build to see if we are done or not: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.32/32/ |
|
The jdt.debug was missed :-( @trancexpress : would you touch jdt.debug or should I do that? |
iloveeclipse
added a commit
to iloveeclipse/eclipse.jdt.debug
that referenced
this issue
Mar 21, 2024
|
I've pushed eclipse-jdt/eclipse.jdt.debug#414 |
iloveeclipse
added a commit
to eclipse-jdt/eclipse.jdt.debug
that referenced
this issue
Mar 21, 2024
|
Up to the next SDK build: https://ci.eclipse.org/releng/job/Builds/job/I-build-4.32/33/ |
|
Thanks very much @trancexpress and @iloveeclipse. |
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform.releng.buildtools
that referenced
this issue
Mar 23, 2024
Added TouchBundles with VersionBump to simplify unstable build fixes caused by compiler changes. See eclipse-platform/eclipse.platform.releng.aggregator#1931 See eclipse-platform/eclipse.platform.releng.aggregator#1923
iloveeclipse
added a commit
to eclipse-platform/eclipse.platform.releng.buildtools
that referenced
this issue
Mar 25, 2024
Added TouchBundles with VersionBump to simplify unstable build fixes caused by compiler changes. See eclipse-platform/eclipse.platform.releng.aggregator#1931 See eclipse-platform/eclipse.platform.releng.aggregator#1923
Wittmaxi
pushed a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this issue
Apr 2, 2024
simple and modern UI/UX for finding/replacing in eclipse. Updated bundles with comparator errors See: eclipse-platform/eclipse.platform.releng.aggregator#1923
iloveeclipse
added a commit
to iloveeclipse/eclipse.platform.releng.aggregator
that referenced
this issue
Apr 14, 2024
iloveeclipse
added a commit
that referenced
this issue
Apr 14, 2024
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this issue
Jul 18, 2024
gayanper
pushed a commit
to gayanper/eclipse.jdt.core
that referenced
this issue
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See: https://download.eclipse.org/eclipse/downloads/drops4/I20240320-0740/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt
Recently two big changes were merged in JDT core:
Likely each results in some of the comparator errors.
For fixing the errors, see: https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/wiki/Platform-Releng-Faq#how-to-fix-unstable-build
The text was updated successfully, but these errors were encountered: