Skip to content

Commit

Permalink
Remove erroneous assertion from browser test #1455
Browse files Browse the repository at this point in the history
The browser test case
test_isLocationForCustomText_isSetUrlNotCustomTextUrlAfterSetText
validates that after setting a browser URL this same URL is then
returned by Browser#getURL(). However, the Browser API does not
guarantee this behavior and the assertion is even unnecessary for the
scenario to be tested, which is already covered by other assertions at
the proper level of abstraction.

This change removes the unnecessary assertion.

Contributes to
#1455
  • Loading branch information
HeikoKlare committed Sep 10, 2024
1 parent ca113ca commit 1ff15af
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,6 @@ public void test_isLocationForCustomText_isSetUrlNotCustomTextUrlAfterSetText()
locationChanged.set(false);
browser.setUrl(url.toASCIIString());
assertTrue("Time Out: The Browser didn't navigate to the URL", waitForPassCondition(locationChanged::get));
assertEquals("Url is wrongly considered Custom Text Url", URI.create(browser.getUrl()), url);
assertFalse("The navigated URL is falsly indicated to be the custom text URL", browser.isLocationForCustomText(browser.getUrl()));
}

Expand Down

0 comments on commit 1ff15af

Please sign in to comment.