Assign Windows runtime rescaling to Display instead of DPIUtil #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
requested review from
lshanmug,
niraj-modi and
sravanlakkimsetti
as code owners
akoch-yatta
reviewed
Jul 23, 2024
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
I like inlining that logic into Display. Especially as it makes it possible to change the setting on runtime
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
display-rescaleatruntime
branch
from
41e26ca to
784ffc7
Compare
Currently, the runtime rescaling of shells/widgets on Windows is tied to a property in the DPIUtil class. Since that class is internal, the property can only be set via a VM argument at startup but cannot be changed or at least retrieved during runtime from outside the SWT bundle. This change reduces the DPIUtil property to a global setting that may be used to set the behavior for a whole application (in particular an SWT application) but move the actual state handling for runtime rescaling behavior to the Display class. This allow to retrieve and change the value directly on the Display, on which also the DPI awareness for the UI thread is initialized. As a side effect, it improves testability as a properly configured display can be used instead of changing the global state of DPIUtil.
HeikoKlare
force-pushed
the
display-rescaleatruntime
branch
from
784ffc7 to
4952b46
Compare
HeikoKlare
added a commit
to HeikoKlare/www.eclipse.org-eclipse
that referenced
this pull request
Nov 5, 2024
HeikoKlare
added a commit
to HeikoKlare/www.eclipse.org-eclipse
that referenced
this pull request
Nov 5, 2024
HeikoKlare
added a commit
to HeikoKlare/www.eclipse.org-eclipse
that referenced
this pull request
Nov 5, 2024
HeikoKlare
added a commit
to eclipse-platform/www.eclipse.org-eclipse
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the runtime rescaling of shells/widgets on Windows is tied to a property in the DPIUtil class. Since that class is internal, the property can only be set via a VM argument at startup but cannot be changed or at least retrieved during runtime from outside the SWT bundle.
This change reduces the DPIUtil property to a global setting that may be used to set the behavior for a whole application (in particular an SWT application) but move the actual state handling for runtime rescaling behavior to the Display class. This allow to retrieve and change the value directly on the Display, on which also the DPI awareness for the UI thread is initialized. As a side effect, it improves testability as a properly configured display can be used instead of changing the global state of DPIUtil.