Text in Dialog was cutoff due to invalid use of AdjustWindowRectEx

[ShahzaibIbrahim]

AdjustWindowRectEx does not take DPI into account. So using AdjustWindowRectExForDpi and passing the zoom level to retrieve correct coordinates and scaling accordingly.

How to Reproduce

• Run the Runtime Workspace with the following VM Arguments on 200% monitor

-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true

• Add a class and create a conditional breakpoint
• Double click on Breakpoint to remove it
• Maximize the main IDE window
• The dialog will appear with the text cutoff
  

Note

Replacing AdjustWindowRectEx in Decoration fixes the issue for dialogs but replacing all the non-dpi calls for AdjustWindowRectEx even though there is no visible difference (but slight difference in returned coordinates) right now but having it DPI dependent makes it consistent.

[github-actions]

Test Results

   494 files     494 suites   9m 3s ⏱️
 4 324 tests  4 306 ✅  18 💤 0 ❌
16 534 runs  16 386 ✅ 148 💤 0 ❌

Results for commit 9cf2c63.

♻️ This comment has been updated with latest results.

[HeikoKlare]

One first comment on the new usage of the Windows API method: The method has been introduced for Windows 10 1607 (https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-adjustwindowrectexfordpi#requirements). This means:

• We should guard its calls by a version check and use the old (non-DPI-aware) method if that method is not met (like, e.g., for getSystemMetrics(ForDpi), as done in Widget#getSystemMetrics()
• We should load the native method dymically to avoid a linker error on platforms that do not provide that method. This is to avoid the issue that we had before that SWT actually required rather update-to-date Windows versions due to rather new methods being statically linked to. For example, take a look at how GetSystemMetricsForDpi is called in os.c.

[HeikoKlare]

Replacing usages of that method with the DPI-dependent version makes sense.

I have updated the PR by merging the commits and fixing copy-paste errors in the documentation.

Still I am non-deterministically getting wrongly scaled versions of dialogs, e.g., this one completely missing the checkbox to not show that message again:

I also have a question regarding the DPI parameter of the newly adapted method, which may be related to the issue.

[HeikoKlare]

The change itself looks sound, but I cannot successfully validate that it has the intended effect. With the change, I now always get a dialog that is cut off (not showing the checkbox):

[HeikoKlare]

Turns out that the native adaptation was erroneous (linking to a wrong library), so that the method always returned false. I've fixed that with 99cf55d.

For me, dialogs now show up in the correct size for all scenarios (that I have tested). E.g., in the originally documented scenario (200% monitor), it looks as expected:

@ShahzaibIbrahim can you please evaluate whether the change work as expected as well?

[ShahzaibIbrahim]

@HeikoKlare it is working as expected.