-
Notifications
You must be signed in to change notification settings - Fork 186
Resolve resources URLs as file-URLs if running in an OSGi environment #2024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve resources URLs as file-URLs if running in an OSGi environment #2024
Conversation
Test Results 539 files - 6 539 suites - 6 31m 17s ⏱️ + 3m 25s For more details on these failures, see this check. Results for commit 44c66fc. ± Comparison against base commit f468eca. This pull request removes 37 tests.♻️ This comment has been updated with latest results. |
HeikoKlare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it good to add an Equinox dependency to the SWT tests? I find that a bit strange since those tests are (outside of an I-Build) executed as plain JUnit tests without any OSGi environment.
In case this is reasonable, we should probably remove the PLUGIN_PATH property from the build scripts, as that one is only used for the SWT tests, isn't it?
3442428 to
b46610a
Compare
Don't consider the 'PLUGIN_PATH' property anymore, which is set in I-build tests and whose handling doesn't work anymore. Fixes eclipse-platform#2001
b46610a to
44c66fc
Compare
That was indeed not ideal and I just used that since avoiding it seemed cumbersome and it worked in all cases (by chance) as described initially because the class-loader then already returned file URLs.
Good point. I checked all the SDK git repos and didn't found another use of that property. So I think we can remove it. I'll create a follow up in the |
For the record, see eclipse-platform/eclipse.platform.releng.aggregator#2989. |
Don't consider the 'PLUGIN_PATH' property anymore, which is set in I-build tests and whose handling doesn't work anymore.
Fixes #2001 (hopefully).