Skip to content

Remove hue from ImageColorTransformer#forHSB #2060 #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Remove hue from ImageColorTransformer#forHSB #2060 #2091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ....eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/image/ImageColorTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ public interface ImageColorTransformer {

public static final ImageColorTransformer DEFAULT_DISABLED_IMAGE_TRANSFORMER = switch (IMAGE_DISABLEMENT_ALGORITHM) {
case IMAGE_DISABLEMENT_ALGORITHM_GTK -> ImageColorTransformer.forRGB(0.5f, 0.5f, 0.5f, 0.5f);
case IMAGE_DISABLEMENT_ALGORITHM_DESATURATED -> ImageColorTransformer.forHSB(1.0f, 0.2f, 0.9f, 0.5f);
case IMAGE_DISABLEMENT_ALGORITHM_DESATURATED -> ImageColorTransformer.forSaturationBrightness(0.2f, 0.9f, 0.5f);
default -> ImageColorTransformer.forGrayscaledContrastBrightness(0.2f, 2.9f);
};

RGBA adaptPixelValue(int red, int green, int blue, int alpha);

public static ImageColorTransformer forHSB(float hueFactor, float saturationFactor, float brightnessFactor,
public static ImageColorTransformer forSaturationBrightness(float saturationFactor, float brightnessFactor,
float alphaFactor) {
return (red, green, blue, alpha) -> {
float[] hsba = new RGBA(red, green, blue, alpha).getHSBA();
float hue = Math.min(hueFactor * hsba[0], 1.0f);
float hue = hsba[0];
float saturation = Math.min(saturationFactor * hsba[1], 1.0f);
float brightness = Math.min(brightnessFactor * hsba[2], 1.0f);
float alphaResult = Math.min(alphaFactor * hsba[3], 255.0f);
Expand Down
Loading