[win32] Adjust wrong size after DPI fix in Shell #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoch-yatta
force-pushed
the
win32-fix-dpi-shell-poschange
branch
from
47af98e to
45e3507
Compare
akoch-yatta
force-pushed
the
win32-fix-dpi-shell-poschange
branch
from
45e3507 to
3983021
Compare
HeikoKlare
force-pushed
the
win32-fix-dpi-shell-poschange
branch
from
3983021 to
008dce6
Compare
This commit addresses an issue with the logic fixing a missing DPI change event from windows in the Shell#WM_WINDOWPOSCHANGED callback. It is no longer necessary, because the causing issue is that in some scenarios a sub shell is positioned on a random monitor. Solution is to adapt the nativeZoom of the sub Shell after the handle was created.
akoch-yatta
force-pushed
the
win32-fix-dpi-shell-poschange
branch
from
008dce6 to
6c4bd61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the logic fixing a missing DPI change event from windows in the Shell#WM_WINDOWPOSCHANGED callback. It is no longer necessary, because the causing issue is that in some scenarios a sub shell is positioned on a random monitor. Solution is to adapt the nativeZoom of the sub Shell after the handle was created.
The PR adapts the implementation done in #1863 which was not correct.
To me this scenario only appears, when starting the RCP from the Explorer (e.g. not a command prompt!). I didn't event have the effect on all RCPs, but at least on the I-Build RCPs, e.g. I can reproduce it on https://download.eclipse.org/eclipse/downloads/drops4/I20250519-0040/download.php?dropFile=eclipse-SDK-I20250519-0040-win32-x86_64.zip. Newer ones will probably have the effect as well.
Primary Monitor 175%, secondary monitor 125%, have the IDE on the Primary monitor and hover over a class.
Important This PR sadly doesn't fully solve all issues as there is another issue hidden in Table, that can scale the scroll width/height of the Table to a value, that does not fit into the scaled Shell and scrollbars will appear, when they shouldn't