Process events until parent shell is activated #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2025
jonahgraham
force-pushed
the
fix-unstable-test
branch
2 times, most recently
from
d27585a to
ffba498
Compare
|
Test commit with |
Test Results 118 files ±0 118 suites ±0 11m 53s ⏱️ ±0s Results for commit 6777ba1. ± Comparison against base commit 1eabfa3. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
fix-unstable-test
branch
2 times, most recently
from
8cc0c1c to
50a12a5
Compare
|
The test I am modifying was a regression test for https://bugs.eclipse.org/bugs/show_bug.cgi?id=436841, but only tested 1 of the 4 events. I added to the test all the events. The test was also written before GTK4 (???) and was disabled on non-x11. The test is now enabled on x11. I'll updated the commit message to include the above on my next push. |
The tests have successfully run 1000x, so I think this is ready to go. |
jonahgraham
force-pushed
the
fix-unstable-test
branch
from
50a12a5 to
2d0e5ac
Compare
It may take some event cycles before the parent shell that is getting focus/activation back gets the notification. Therefore wait until the Activate listener is called This test had bitrotten due to order of operation issues, see eclipse-platform#2591 for details on that. This test was a regression test for https://bugs.eclipse.org/436841, but only tested 1 of the 4 events. I added to the test all the events. The test was also written before GTK4 (???) and was disabled on non-x11. The test is now enabled on x11.
jonahgraham
force-pushed
the
fix-unstable-test
branch
from
2d0e5ac to
6777ba1
Compare
jonahgraham
commented
Oct 7, 2025
| assertTrue(listenerCalled); | ||
| } | ||
| public void test_activateEventSend() throws InterruptedException { | ||
| assumeTrue((SwtTestUtil.isGTK && SwtTestUtil.isX11) || SwtTestUtil.isGTK4, |
There was a problem hiding this comment.
Note that because of #2591 this assumption fails, even on GTK3 + x11.
When I had done the 1000x repeated test I had included the fix in this PR as well to make sure it ran.
Once #2591 is done this test will actually run properly.
In hindsight, I think I made it too complicated by having this as two PRs. Two commits in the one PR would have been sufficient (and simpler for me)
jonahgraham
added a commit
to jonahgraham/eclipse.platform.swt
that referenced
this pull request
Oct 7, 2025
The value of org.eclipse.swt.internal.gdk.backend is not set until a display is created at least once since this value is assigned in the Display constructor. To be able to detect if Display has been created, set "org.eclipse.swt.internal.gdk.backend" on wayland too. A similar problem exists for org.eclipse.swt.internal.gtk.version in relation to OS. This is a fix for a regression caused by moving the setting of org.eclipse.swt.internal.gdk.backend from OS to Display in 5d67ce6. That commit fixed an unrelated bug, but sometimes bad initialization of isX11 is an unintended side effect causing tests to be skipped or run in unexpected ways since isX11 was not correct. See for example eclipse-platform#2592 for a test that was silently being skipped and had bitrotten as a result.
jonahgraham
added a commit
to jonahgraham/eclipse.platform.swt
that referenced
this pull request
Oct 7, 2025
The value of org.eclipse.swt.internal.gdk.backend is not set until a display is created at least once since this value is assigned in the Display constructor. To be able to detect if Display has been created, set "org.eclipse.swt.internal.gdk.backend" on wayland too. A similar problem exists for org.eclipse.swt.internal.gtk.version in relation to OS. This is a fix for a regression caused by moving the setting of org.eclipse.swt.internal.gdk.backend from OS to Display in 5d67ce6. That commit fixed an unrelated bug, but sometimes bad initialization of isX11 is an unintended side effect causing tests to be skipped or run in unexpected ways since isX11 was not correct. See for example eclipse-platform#2592 for a test that was silently being skipped and had bitrotten as a result.
jonahgraham
added a commit
to jonahgraham/eclipse.platform.swt
that referenced
this pull request
Oct 8, 2025
The value of org.eclipse.swt.internal.gdk.backend is not set until a display is created at least once since this value is assigned in the Display constructor. To be able to detect if Display has been created, set "org.eclipse.swt.internal.gdk.backend" on wayland too. A similar problem exists for org.eclipse.swt.internal.gtk.version in relation to OS. This is a fix for a regression caused by moving the setting of org.eclipse.swt.internal.gdk.backend from OS to Display in 5d67ce6. That commit fixed an unrelated bug, but sometimes bad initialization of isX11 is an unintended side effect causing tests to be skipped or run in unexpected ways since isX11 was not correct. See for example eclipse-platform#2592 for a test that was silently being skipped and had bitrotten as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may take some event cycles before the parent shell that is getting focus/activation back gets the notification. Therefore wait until the Activate listener is called