Reverting a side effect introduced in #2526 #2647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the changes introduced in eclipse-platform#2526 where getImageData and getScaledImageData were mistakenly interchanged. The initial approach aimed to use this method in loadImageDataClosestTo when images couldn't be loaded at the exact size. However, the final implementation used loadImageData(zoom) instead, making those changes unnecessary. These leftover modifications were an unintended side effect, and this commit removes them.
HeikoKlare
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
The change is sound and was obviously an oversight in #2526 after iterating to the final version of that PR.
For the record: this resolves a potential StackOverflowError because of cyclic calls between two methods.
java.lang.StackOverflowError
at org.eclipse.swt.graphics.Image.getImageData(Image.java:1288)
at org.eclipse.swt.graphics.Image$ExistingImageHandleProviderWrapper.newImageData(Image.java:2048)
at org.eclipse.swt.graphics.Image.getImageData(Image.java:1288)
at org.eclipse.swt.graphics.Image$ExistingImageHandleProviderWrapper.newImageData(Image.java:2048)
at org.eclipse.swt.graphics.Image.getImageData(Image.java:1288)
at org.eclipse.swt.graphics.Image$ExistingImageHandleProviderWrapper.newImageData(Image.java:2048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts the changes introduced in #2526 where getImageData and getScaledImageData were mistakenly interchanged. The initial approach aimed to use this method in loadImageDataClosestTo when images couldn't be loaded at the exact size. However, the final implementation used loadImageData(zoom) instead, making those changes unnecessary. These leftover modifications were an unintended side effect, and this commit removes them.