Fix some GTK4 deprecation warning #2726
Closed
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace gtk_widget_get_allocation with gtk_widget_compute_bounds (with GTK4 version check) - Replace gtk_css_provider_load_from_data with gtk_css_provider_load_from_string - Replace gtk_widget_translate_coordinates with gtk_widget_compute_point These changes reduce GTK4 deprecation warnings from 159 to 156. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
jonahgraham
reviewed
Oct 31, 2025
| *******************************************************************************/ | ||
|
|
||
| /* Note: This file was auto-generated by org.eclipse.swt.tools.internal.JNIGenerator */ | ||
| /* DO NOT EDIT - your changes will be lost. */ |
There was a problem hiding this comment.
@laeubi these files are auto generated from GTK4.java and OS.java respectively, so the changes should be made at the Java level for this.
|
PS If the problem really needs to be solved in the C code, then it needs to be added to os_custom.c and in OS.java set: |
|
@jonahgraham thanks for the pointer I'll take a look to find out what would be the proper way here. |
|
Closing this one as it manually changes two files that should be auto generated and does so wrong e.g. binding for gtk_css_provider_load_from_data calling gtk_css_provider_load_from_string |
|
Tip: gtk_css_provider_load_from_string/bytes has a since 4.12 while SWT still supports 4.0 (or at least claims to do so). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reduce GTK4 deprecation warnings from 159 to 156.