-
Notifications
You must be signed in to change notification settings - Fork 187
An attempt to fix test_evalute_Cookies #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results 111 files - 7 111 suites - 7 16m 25s ⏱️ +10s For more details on these errors, see this check. Results for commit f044cd4. ± Comparison against base commit a0d6ffc. This pull request removes 56 tests.This pull request skips 1 test.♻️ This comment has been updated with latest results. |
|
As a start you might want to print the content or change the assertFalse(res.isEmpty()) to assertEquals("", res) so the actual value is seen. |
Just a guess the failure could be somehow related to redirect from https://www.eclipse.org/swt to https://eclipse.dev/eclipse/swt/. See eclipse-platform#2804
a619370 to
f044cd4
Compare
Are you able to run this test on latest webkit? Our RHEL 9.6 version is surely very old |
|
I can't reproduce the problem locally on webkitgtk-2.50.2-1.fc43 |
|
One thing worth considering here is that version 2.50 no longer links against libsoup but rather libsoup3 and it might actually be a change in libsoup . https://webkitgtk.org/2025/10/07/webkitgtk-soup2-deprecation.html indicates that for now only some distros dropped libsoup (2.x) support but starting with current indevelopment version of webkit (2.52) only libsoup3 is supported. This library is what handles the cookie stuff IIRC. |
|
Putting this upstream change here for later analysis (if needed) https://github.com/WebKit/WebKit/pull/51819/files#diff-38776530271615386c97930733aae45d563980de6a3ae553cfeb49db1458e63f |
Just a guess the failure could be somehow related to redirect from https://www.eclipse.org/swt to https://eclipse.dev/eclipse/swt/.
See #2804