'Restore Defaults' button uses a different value when USE_MARKER_LIMITS preference is false.

[eobrienPilz]

The FiltersConfigurationDialog has a 'Restore Defaults' button to restore the dialog to its default state.

If USE_MARKER_LIMITS preference is false then 'items per group' is restored to 1000.

int markerLimits = useMarkerLimits ? preferenceStore.getInt(IDEInternalPreferences.MARKER_LIMITS_VALUE) : 1000;

This is in contrast to the default value for 'items per group' of 100 when Eclipse is first launched.

node.putInt(IDEInternalPreferences.MARKER_LIMITS_VALUE, 100);

The restore default button should restore the 'items per group' to the same value as on first launch.

• note : this issue is not normally reproducible in Eclipse as USE_MARKER_LIMITS preference is true by default.
  It can be seen when USE_MARKER_LIMITS preference is being set to false via plugin_customization.ini for example.

[deepika-u]

@eobrienPilz
How do i get to FiltersConfigurationDialog? Can you please share the steps to recreate the problem as such.

[eobrienPilz]

@deepika-u
Steps to reproduce

• Add the following line to org.eclipse.platform\plugin_customization.ini
  • org.eclipse.ui.ide/USE_MARKER_LIMITS=false
• Add the following line to the VM arguments section of the launch configuration
  -Declipse.pluginCustomization="path to the code/git/eclipse.platform/platform/org.eclipse.platform/plugin_customization.ini"
• Launch eclipse from the launch configuration
• Open the problem view
• Click the filters button

• Note that use limits is unchecked and the Items per group is disabled
• Note that Items per group default is set to 100
• Click 'Restore Defaults'
• Note that Items per group is set to 1000

[eobrienPilz]

@deepika-u Let me know if you need anything else to reproduce the issue.

[deepika-u]

Hi @eobrienPilz,
I have my eclipse installation at C:\e\i\eclipse-SDK-I20240601-0610_4.32rc2a

• Now i went to path C:\e\i\eclipse-SDK-I20240601-0610_4.32rc2a\eclipse\plugins\org.eclipse.platform_4.32.0.v20240601-0610 and added this line "org.eclipse.ui.ide/USE_MARKER_LIMITS=false" in plugin_customization.ini file.

• Now i went to the eclipse.ini file and under -vmargs section added this line "-Declipse.pluginCustomization=platform:/base/plugins/org.eclipse.platform_4.32.0.v20240601-0610/plugin_customization.ini"

• Launched eclipse.exe and seeing the settings of "filters" as below:
  

• this is the same setting i have changed from 100 default value to 2000 intentionally. I am now seeing the same as checked(and never as unchecked) and 2000 as its value.

• Now i do a "Restore Defaults", it changes back to 100.
  

I am on below environment as of now
Eclipse SDK
Version: 2024-06 (4.32)
Build id: I20240601-0610
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Oracle Corporation
Java runtime version: 22+36-2370
Java version: 22

This is 4.32 rc2 build. I have also tried on 4.33 and i am seeing the same behavior. Tried multiple times. Sorry for the delayed response. I am not seeing the behavior of use limits as unchecked never. Am i missing any steps listed above or if i am wrong at any of the step. When always do a "Restore Defaults" it is going back to 100 as usual(never 1000).