Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long deprecated Navigator view #644

Closed
akurtakov opened this issue Mar 17, 2023 · 15 comments
Closed

Remove long deprecated Navigator view #644

akurtakov opened this issue Mar 17, 2023 · 15 comments
Milestone

Comments

@akurtakov
Copy link
Member

It has been deprecated years ago (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=549953 ) and deprecation period ended even for 2022-06. For 2023-03 I've cleaned whatever I found and will start removing it gradually for June release.

akurtakov added a commit to akurtakov/eclipse.platform.ui that referenced this issue Mar 17, 2023
@trancexpress
Copy link
Contributor

Who exactly is benefiting from this removal? There are committers who are burdened by maintaining the code?

@akurtakov
Copy link
Member Author

We got to a state where any meaningful improvement to anything is hindered by the amount of legacy shipped . Here is just one example #500 (comment) . Having the code is not just maintaining it, it's navigating the codebase, making the mindmap of what/where/how/etc. and when for almost everything there is half a dozen different way to do it - good luck on improving anything (not just bug fixes) and no one even dares to think of any slightly bigger improvement.

@trancexpress
Copy link
Contributor

-1 from me for this change, as usual do whatever.

@akurtakov
Copy link
Member Author

Let's see what the majority vote would be.
For the record - such concerns should be raised when something is deprecated for removal not when it's actually being removed.

@mickaelistria
Copy link
Contributor

-1 from me for this change

Can you please elaborate why? We need to collect data to ensure we take the best decision for the project continued success. So arguments in favor of keeping this view are still welcome (although they'd better have been expressed when deprecation was agreed upon).

@trancexpress
Copy link
Contributor

Let's see what the majority vote would be. For the record - such concerns should be raised when something is deprecated for removal not when it's actually being removed.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=549953#c15

Can you please elaborate why? We need to collect data to ensure we take the best decision for the project continued success. So arguments in favor of keeping this view are still welcome (although they'd better have been expressed when deprecation was agreed upon).

Because I use the view.

@mickaelistria
Copy link
Contributor

Thanks for linking to your comment on previous discussion; everything is done proper then if the comment was captured and discussed earlier.

Because I use the view.

Then you can copy the code to some plugin and offer it on Marketplace ;)

@iloveeclipse
Copy link
Member

https://bugs.eclipse.org/bugs/show_bug.cgi?id=549953#c15

The contents of bin folders are shown for me in Project Explorer, if I uncheck "java output folders"

image

Beside this, I'm +-0 here.

@laeubi
Copy link
Contributor

laeubi commented Mar 17, 2023

Another solution would be to to add missing features to the new view.

e.g. a rename file shortcut

I also very much like the EGit Shortcut "Open in System Explorer"

@vogella
Copy link
Contributor

vogella commented Mar 20, 2023

+1 for removal, I have never used it.

akurtakov added a commit to akurtakov/eclipse.platform.ui that referenced this issue Mar 20, 2023
akurtakov added a commit that referenced this issue Mar 29, 2023
akurtakov added a commit to eclipse-platform/eclipse.platform.common that referenced this issue Mar 30, 2023
@vogella
Copy link
Contributor

vogella commented Mar 30, 2023

Thanks @akurtakov, now we allow have two slightly different implementations providing almost the same functionality, Project explorer and Package Explorer.

@akurtakov akurtakov added this to the 4.28 M1 milestone Mar 30, 2023
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Apr 2, 2023
The long deprecated for removal navigator view has been removed
from upcoming Eclipse Platform.

I don't know if there are other locations in CDT that are affected,
but this change covers the compilation failure of the removal.

xref: eclipse-platform/eclipse.platform.ui#644
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Apr 2, 2023
The long deprecated for removal navigator view has been removed
from upcoming Eclipse Platform.

I don't know if there are other locations in CDT that are affected,
but this change covers the compilation failure of the removal.

xref: eclipse-platform/eclipse.platform.ui#644
jonahgraham added a commit to eclipse-cdt/cdt that referenced this issue Apr 2, 2023
The long deprecated for removal navigator view has been removed
from upcoming Eclipse Platform.

I don't know if there are other locations in CDT that are affected,
but this change covers the compilation failure of the removal.

xref: eclipse-platform/eclipse.platform.ui#644
@jonahgraham
Copy link
Contributor

I have sent an email to the PMC on this topic - the link should be https://www.eclipse.org/lists/eclipse-pmc/msg04130.html once it is archived.

@Bananeweizen
Copy link
Contributor

I also very much like the EGit Shortcut "Open in System Explorer"

Even though I contributed that one, it's still just a workaround. Much better is to install the EasyShell plugin, which will provide you with your personalized shell (e.g. cmd, powershell, Terminal, bash, ...). Highly recommended.

@mpalat
Copy link

mpalat commented Apr 3, 2023

-1 still for me - I still use this frequently while doing compiler development - refer https://bugs.eclipse.org/bugs/show_bug.cgi?id=549953#c26 for conditions acceptable for me for the removal - essentially captured in https://bugs.eclipse.org/bugs/show_bug.cgi?id=550385

@merks
Copy link
Contributor

merks commented Apr 4, 2023

It seems the archiving of mailing lists is broken again with nothing for April:

https://www.eclipse.org/lists/eclipse-pmc/2023/

I opened this issue:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants