-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 2018 deprecated runtime contenttype extension point #1627
Remove 2018 deprecated runtime contenttype extension point #1627
Conversation
3a2947f
to
686f029
Compare
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
@HannesWell I do not see the version increase commit from eclipse-platform-bot in this PR. Did I do something wrong? I will now rebase and see if the bot can add the version increase commit now. |
In 2018 we marked this extension point for deletion, lets remove it for 2025-03.
686f029
to
73856e9
Compare
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.
The log of the publication workflow says that the bot is not permitted to push to your repository. |
No, but I learned from https://github.com/orgs/community/discussions/5634 that: if a PR is created from a fork living under an organisation (rather than an individual) it's not possible to allow edits by maintainers So instead of sending PR from @vogellacompany I'm supposed to send them from @vogella to get this working. Thanks for the answer @HannesWell |
New PR #1644 |
In 2018 we marked this extension point for deletion, lets remove it for 2025-03.